Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto registrating in optional collector in spring-boot-starter #1166

Open
arseny-tl opened this issue Jul 5, 2023 · 2 comments
Open

Auto registrating in optional collector in spring-boot-starter #1166

arseny-tl opened this issue Jul 5, 2023 · 2 comments

Comments

@arseny-tl
Copy link

Hello!
Im using spring starter.
Based on #679 there is a programmatic way to register application in optional server collector. Currently, i have >80 microservices, which i am trying to migrate to optional collector. It seems to me a little bit odd that i need to add to all microservices startup/shutdown hooks to register / deregister application from collector. Even if i just created my own starter which will register/deregister automatically i would need to update >80 pom files. Do you think it is possible to add property 'collector-server-url' and reuse it in AutoConfiguration to automatically register based on application properties?
I can try to add this functionality.

@evernat
Copy link
Member

evernat commented Jul 16, 2023

It seems to me that it would be needed to have values for applicationName and applicationNodeUrl and not only for collectServerUrl, when calling the MonitoringFilter.registerApplicationNodeInCollectServer(applicationName, collectorServerUrl, applicationNodeUrl).
What would you do for those parameters ?

@evernat
Copy link
Member

evernat commented Aug 2, 2023

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants