Implement jasmine.clock().asyncTick() #1762
Conversation
I had to make the existing loop into an async loop, using a state machine with a switch statement. (This is how babel transpiles async-await, although I did this manually.)
Use (the real) setTimeout for emptying the microtask queue.
I haven't figured out where the docs are to draft an update yet
|
Is there any update on this? |
|
Thank you for the PR. I'm sorry you didn't get a response much sooner. This is impressive work, but I'm not planning to merge it. The async loop transformation adds considerable complexity to what was already one of the harder parts of Jasmine to work with. That's not always a deal-breaker, but I have to weigh the maintainability cost against the value of the feature. In this case I think the cost outweighs the benefit.
|
Description
Adds an
.asyncTick()method tojasmine.Clock, and to the internalDelayedFunctionScheduler. These are just a slight variation on the existing.tick()methods, but they allow microtasks to run.There is an existing loop in
DelayedFunctionSchedulerfor running the scheduled timeouts/intervals.I just want to make that an async loop, and call clearStack() to run any pending microtasks.
Simple.
Unfortunately, it requires transforming the code.
I changed the existing loop into an async loop, using a state machine with a switch statement. (This is how babel transpiles async-await, although I did this manually.)
Motivation and Context
Closes #1725
This makes it possible to test code that uses timeouts in combination with Promises or async-await.
How Has This Been Tested?
I'm fairly confident that the existing tests verify the transformed loop with the switch statement.
Thus, I've only added a handful of tests that verify microtasks get run.
Problems:
Types of changes
Checklist: