New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up misguided legacy changes #4266
Projects
Comments
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the distant past there have been changes of questionable value, often breaking, often complicating and/or pessimizing the code, and sometimes removing pre-existing tests. I consider #3843 a good example of this type of change. I'm sure that example is one of many, because I encountered similar changes when I triaged the open issues and pull requests in stage 1 of #4244. In addition, I have seen many similarly unfortunate changes in Underscore, often (but not always) by the same author.
Many small changes make a big difference, and I suspect that hunting down and reverting as many of these changes as possible would slim down and speed up the code considerably. Unfortunately, this is easier said than done, for three main reasons:
To address this, I would like to do the following:
future
branch.future
branch.Candidate list (to be updated as the discussion progresses):
The text was updated successfully, but these errors were encountered: