Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Size After 2.0.0 #37

Open
eygraber opened this issue Apr 5, 2020 · 11 comments
Open

Library Size After 2.0.0 #37

eygraber opened this issue Apr 5, 2020 · 11 comments

Comments

@eygraber
Copy link

eygraber commented Apr 5, 2020

Updating my project to use the new version of this library added ~3mb to my app size. Are there any plans to address that?

@jakoss
Copy link

jakoss commented May 4, 2020

Are you sure library is to blame? I analyzed my apk and well - 459,3 KB of db file
image

And literally 5,5 KB of code:
image

I don't see how this library could weigh so much as 3 MB.

@eygraber
Copy link
Author

eygraber commented May 4, 2020

The db gets compressed in assets. When you install it, it gets copied to the filesystem, where it is uncompressed.

@jakoss
Copy link

jakoss commented May 4, 2020

Ok, but is that really a problem? Apk size is what matters, yes. But additional 3 MB on device? Http cache gets this large in a few hours

@eygraber
Copy link
Author

eygraber commented May 4, 2020

It definitely depends on the use case. Some of my apps it wouldn't matter, and some of them really do matter greatly.

@jakoss
Copy link

jakoss commented May 4, 2020

Ok. I'm not sure if anything can be done here. Pretty much all the space is taken by database, which is basically one table with 3 columns. All of this data is reason why this library is so useful to me and I'm not sure if anything can be removed without functionality loss

@eygraber
Copy link
Author

eygraber commented May 4, 2020

Probably the best way to handle this would be to properly host the database somewhere (like what was happening on GitHub before, but using some server(less) tech).

@jakoss
Copy link

jakoss commented May 4, 2020

Honestly i wouldn't use that library if it required internet connection... It's just too simple and too fundamental to complicate it that much. Network usage always have big implications which ultimately makes the library complicated without a proper reason. Maintainer should be able to make this decision, but for me - 3 MB of installed app size is nothing compared to network based library

@eygraber
Copy link
Author

eygraber commented May 4, 2020

You know it required an internet connection up until the latest version, right?

@jakoss
Copy link

jakoss commented May 4, 2020

I'm using it for like 2 months, so i'm talking only about that version

@eygraber
Copy link
Author

eygraber commented May 4, 2020

There have been people using it for years with an internet connection, and not a very optimized one.

If you tell me that 3mb extra reported in the app size isn't a problem, then I'll tell you that a sub kilobyte network request/response that happens once per the lifetime of the app isn't a problem 😄

@mahmoudElfeel67
Copy link

@eygraber did you find an alternative ? less size ?

@github-staff github-staff deleted a comment from lucass235 Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants