-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows installer #247
Comments
I tried that way, but to no avail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What an installer should do and what should be fixed:
SHOULD NEVER require UAC to install (rights asInvoker is enough)
should by default install to
C:\Program Files\MediacenterJS
Include the
node.exe
file. Or download during the installation process to program folder LOCALLY into the BIN folder ! and probably the npm tool. And the dependencies.package.json
should contain some line like{ "engines" : { "node" : ">=8.5.0" } }
a.
fs-extra
: use the newconst fs = require('fs').promises
way to not need fs-extra and work with node>10.b. sqlite3 has been build against a specific version of node. gyp will mess this up. It does usually work, if for sqlite3, the newest version is used, because pre-gyp kicks in and downloads the precompiled binary.
c. socket.io needs to be updated as well
additionally: add electron to be able to run in background, only having a tray icon or alike (no need to package into electron, could also be downloaded during install).
should run
compact /C /S:node_modules *.*
to NTFS-Compact that directory to keep installed size small - or:compact /C /S node_modules\*.*
to include node_modules for all future modules.run
del /F/S/Q node_modules & npm install
(rd /S/Q node_modules
) at the end - if dependencies were not packed into the installer for the specific node version.bin\node...
path to work (best done in the mediacenter.exe)JADE became PUG ...
The text was updated successfully, but these errors were encountered: