Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling issue on edit chat input #2856

Merged
merged 1 commit into from May 3, 2024
Merged

Fix scrolling issue on edit chat input #2856

merged 1 commit into from May 3, 2024

Conversation

QuentinMacheda
Copy link
Contributor

Describe Your Changes

  • Remove hidden overflow property to allow scrolling
  • Update layout -> submit and cancel buttons are now below the textarea instead of being next to it.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement New feature or request label May 2, 2024
@Van-QA Van-QA requested review from a team and urmauur May 2, 2024 07:56
louis-jan
louis-jan approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA
Copy link
Contributor

Van-QA commented May 3, 2024

hi @QuentinMacheda, could you help us resolve the linter issue, many thanks
image

@Van-QA Van-QA merged commit 2016eae into janhq:dev May 3, 2024
4 of 7 checks passed
@QuentinMacheda
Copy link
Contributor Author

QuentinMacheda commented May 3, 2024 •
edited

hi @QuentinMacheda, could you help us resolve the linter issue, many thanks image

Hi @Van-QA, sorry about that. I fixed the issue, do you want me to make another PR ?

@Van-QA
Copy link
Contributor

Van-QA commented May 3, 2024

thank @QuentinMacheda, that would be really helpful

@QuentinMacheda QuentinMacheda deleted the fix/edit-chat-input branch May 5, 2024 20:04
@Van-QA Van-QA added this to the v0.4.13 Broken Rice milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
Jan
Status: Done
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.

bug: Impossible to scroll when editing a chat input
5 participants
@QuentinMacheda @Van-QA @louis-jan @urmauur @imtuyethan