Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required module `Bigarray' is unavailable #94

Open
talex5 opened this issue Jul 3, 2020 · 8 comments
Open

Required module `Bigarray' is unavailable #94

talex5 opened this issue Jul 3, 2020 · 8 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@talex5
Copy link

talex5 commented Jul 3, 2020

I'm trying to find out why capnp master's tests don't work on OCaml 4.07, and the Required module `Bigarray' is unavailable error seems to be connected to Base_quickcheck. I thought it would be good to enable CI on this repository to see if it shows up here too.

If you'd like to enable ocaml-ci here, go to https://github.com/apps/ocaml-ci and add the GitHub app to this organisation (making sure to limit it to just the base repository when prompted). I've already added janestreet to the whitelist, so no other configuration should be needed.

@ghost
Copy link

ghost commented Jul 6, 2020

Hi Thomas,

Thanks for the whitelist! I admit I feel a bit nervous about enabling CI on individual projects under github.com/janestreet. Given that we have only a few people managing a large number of repositories, we prefer to have solutions that can be applied to all repositories the same way rather than have special cases. And adding a CI to each repository under github.com/janestreet feels like it would be a lot of places to monitor.

However, we are currently planning to create a compound github.com/universe (exact name TBD) repository that will include a copy of all of Jane Street packages + a copy of a few dependencies. Enabling the CI on this repository would be more manageable and even seem like a good thing to do. /cc @snowleopard who is preparing this repository.

@talex5
Copy link
Author

talex5 commented Jul 6, 2020

The default is to apply a GitHub App to all repositories, but I suggest limiting it to just this one to start with. First, to check that it works, and secondly to avoid overloading the CI (we're still scaling it up). But in the UI it's just a matter of choosing either All repositories, or choosing Only select repositories and then selecting the ones you want.

There is a per-organisation dashboard that shows the state of the master branch of each repository. e.g. for mirage: https://ci.ocamllabs.io/github/mirage

@ghost
Copy link

ghost commented Jul 6, 2020

Thanks for the details. I'm going to enable it for "spawn" to start with as this repository is developed on github and I have added ocaml-ci as a discussion topic for our next public release meeting which is Tuesday next week.

@ghost
Copy link

ghost commented Jul 7, 2020

@talex5 could you whitelist github.com/ocaml-dune as well?

@talex5
Copy link
Author

talex5 commented Jul 7, 2020

Done.

@avsm
Copy link

avsm commented Jul 7, 2020

Looks like enabling it on spawn passed except for the lint test, where it discovered a diff for the dune files not following the formatter. https://ci.ocamllabs.io/github/janestreet/spawn/commit/5a67333b07564211a0d294a06f8769f756710cdf/variant/(lint-fmt)

@ghost
Copy link

ghost commented Jul 8, 2020

Indeed, I reformatted the files.

@talex5
Copy link
Author

talex5 commented Jul 18, 2020

BTW, while testing the CI we've set it to require repositories to be selected individually (also, it's often a mistake, when people forget to make a selection). This is why ocaml-dune isn't doing anything at the moment.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 14, 2020
@talex5 talex5 changed the title Enable ocaml-ci for this repository? Required module `Bigarray' is unavailable Feb 22, 2022
talex5 added a commit to talex5/capnp-ocaml that referenced this issue Jul 18, 2023
talex5 added a commit to talex5/capnp-ocaml that referenced this issue Jul 18, 2023
talex5 added a commit to talex5/opam-repository that referenced this issue Jul 19, 2023
CHANGES:

- Update README to talk about stdint, not uint (reported by @liyishuai).
  Also, remove out-of-date list of runtime packages needed. The build system can sort that out.

- Remove all `inlined` attributes (@talex5 capnproto/capnp-ocaml#87 capnproto/capnp-ocaml#88).
  These cause confusing compiler warnings for users, which can't be disabled automatically,
  and the inlining isn't being used anyway since capnproto/capnp-ocaml#83.

- Fix "Unknown interface" error (@talex5 capnproto/capnp-ocaml#85).
  It reported the UUID of the actual object, not the UUID that was requested.
  Also, add `Registry.pp_interface` for better error messages.

- Minor opam fixes (@talex5 capnproto/capnp-ocaml#84).
  Depend on dune >= 2.3 and don't try to build benchmarks; that only works on some platforms.

- Bump minimum OCaml version to 4.08.
  4.07 doesn't work due to janestreet/base#94.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

3 participants