Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-empty lists #141

Open
johnyob opened this issue Oct 21, 2022 · 4 comments
Open

Support for non-empty lists #141

johnyob opened this issue Oct 21, 2022 · 4 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@johnyob
Copy link

johnyob commented Oct 21, 2022

It would be great if Base provided a List.Non_empty module for non-empty lists

type 'a t = (::) of 'a * 'a list
@johnyob johnyob changed the title Support for List.Non_empty lists Support for non-empty lists Oct 21, 2022
@bcc32
Copy link
Member

bcc32 commented Oct 24, 2022

Does the Nonempty_list library do what you need? You can get it by installing core_kernel and using core_kernel.nonempty_list in your dune file.

@johnyob
Copy link
Author

johnyob commented Oct 24, 2022

I was unaware of this Nonempty_list library in Core_kernel.

Nonetheless, it was my understanding that Core_kernel was going to be deprecated at some point. Will this Nonempty_list library be merged into Base or Core?

@bcc32
Copy link
Member

bcc32 commented Oct 26, 2022

Core_kernel the library has been deprecated, but the opam package still remains. We're not planning on merging Nonempty_list into Base or Core anytime soon, but it's possible the best way to handle this is to release it as a separate, one-module package, rather than bundling it with a bunch of unrelated libraries.

I think @staronj or maybe @tov is the right person to think about this (low confidence)?

@tov
Copy link
Contributor

tov commented Oct 26, 2022

That sounds fine to me (low confidence), but I'm wondering if there's a reason not to move it to core.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

4 participants