Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/RFC: Abolish backends::s3::EndPoint or add Custom(function) element #115

Open
passivedragon opened this issue Sep 10, 2023 · 0 comments

Comments

@passivedragon
Copy link

passivedragon commented Sep 10, 2023

Unless I have missed a vital part, it seems like the current S3 implementation is quite restrictive in regards to vendors of S3-compatible buckets. For example, I initially looked at this crate hoping to make use of a cloudflare R2 bucket.

I don't see a fundamental point to have this kind of restriction, beyond sane-defaults. Therefore I think it'd be more useful and flexible to have a simple way of adding custom S3 links. This could either come with the enum serving as defaults, or by adding a Custom() element to the enum, which can be passed a function to parse parameters into a final request url.

It seems to me that the only time these actually matter, is when download_base_url and api_url are set. Even easier could be to simply set them directly, which a passed function could also just do directly if wanted.

If there aren't any problems with this, I'd be happy to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant