-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Rethink storage configuration to align with OTEL #5229
Labels
Comments
4 tasks
4 tasks
yurishkuro
added a commit
that referenced
this issue
May 20, 2024
## Which problem is this PR solving? - part of #5229 ## Description of the changes - added more grpc storage client configuration to align with otel ``` configgrpc.ClientConfig `mapstructure:",squash"` exporterhelper.TimeoutSettings `mapstructure:",squash"` ``` These are not all the configs, but i'll add more based on feedback on this initial approach. ## How was this change tested? - not tested yet ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Harshvir Potpose <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now several PRs that are trying to add support for standard storage backends to v2 are reusing the same configuration for storage as we had in v1. Now is a good time to rethink that configuration, in particular:
priority_dependencies_template
CreateDefaultConfig
because at that point we don't known which storage will be used.The text was updated successfully, but these errors were encountered: