From 31cc9b710c0765f216867b60ac3726942902bf8a Mon Sep 17 00:00:00 2001 From: haanhvu Date: Thu, 7 Dec 2023 21:27:54 +0700 Subject: [PATCH] Fix failed checks Signed-off-by: haanhvu --- cmd/jaeger/internal/exporters/storageexporter/factory.go | 2 +- plugin/storage/clickhouse/config.go | 2 +- plugin/storage/clickhouse/spanstore/empty_test.go | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 plugin/storage/clickhouse/spanstore/empty_test.go diff --git a/cmd/jaeger/internal/exporters/storageexporter/factory.go b/cmd/jaeger/internal/exporters/storageexporter/factory.go index 9f5fa57cd25..2921c2d939a 100644 --- a/cmd/jaeger/internal/exporters/storageexporter/factory.go +++ b/cmd/jaeger/internal/exporters/storageexporter/factory.go @@ -41,7 +41,7 @@ func createTracesExporter(ctx context.Context, set exporter.CreateSettings, conf exporterhelper.WithCapabilities(consumer.Capabilities{MutatesData: false}), exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0}), exporterhelper.WithRetry(exporterhelper.RetrySettings{Enabled: false}), - //Enable queue settings for batch inserts + // Enable queue settings for batch inserts exporterhelper.WithQueue(exporterhelper.QueueSettings{Enabled: true}), exporterhelper.WithStart(ex.start), exporterhelper.WithShutdown(ex.close), diff --git a/plugin/storage/clickhouse/config.go b/plugin/storage/clickhouse/config.go index 04c6488ff92..f44495a423f 100644 --- a/plugin/storage/clickhouse/config.go +++ b/plugin/storage/clickhouse/config.go @@ -19,7 +19,7 @@ type Config struct { Password string `mapstructure:"password"` Database string `mapstructure:"database"` SpansTableName string `mapstructure:"spans_table_name"` - //materialized views' names? + // Materialized views' names? } const ( diff --git a/plugin/storage/clickhouse/spanstore/empty_test.go b/plugin/storage/clickhouse/spanstore/empty_test.go new file mode 100644 index 00000000000..9a0f6645c07 --- /dev/null +++ b/plugin/storage/clickhouse/spanstore/empty_test.go @@ -0,0 +1,4 @@ +// Copyright (c) 2023 The Jaeger Authors. +// SPDX-License-Identifier: Apache-2.0 + +package spanstore