-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails6 Incompability for 1.0.45 #44
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rails: 6.0.2.1
Ruby: 2.7.0p0 (2019-12-25 revision 647ee6f091)
Bundler: 2.1.4
Release 1.0.45 seems to fail when installing with bundler in Rails6.
I have created a brand new Rails6 project and added iyzipay to the gemfile.
When I run
bundle
, bundler installs version1.0.44
of the gem,which depends on
rest-client ~> 1.8
, which is not working properly as tests shows that:I believe this is a rest-client related problem due to this issue.
The solution is simply updating rest-client to ~> 2.0, which is already done in
iyzipay 1.0.45
.But the problem is that when you force bundler to install iyzipay 1.0.45 in your gemfile, like:
Following output occurs when you run
bundle
:I think the problem is that rack dependency of rails6 (actionpack 6) fails to comply with iyzipay rack dependency, which is 1.6.4.
I have forked the repository and updated
rack
dependency to 2.0, which forced me to updaterspec
andrspec-rails
dependencies to 3.8.0.Currenty the tests and my rails6 project are working perfectly well but further testing is required in order to maintain backwards compability of the gem.
I'll generate a PR and hope that this simple solution works for everybody.
The text was updated successfully, but these errors were encountered: