Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with cocogitto #90

Open
berkus opened this issue Apr 13, 2024 · 0 comments
Open

Fails to build with cocogitto #90

berkus opened this issue Apr 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@berkus
Copy link

berkus commented Apr 13, 2024

Describe the bug

Fails to build with latest cocogitto:

   Compiling cocogitto v6.1.0
   Compiling koji v2.2.0
error[E0061]: this method takes 1 argument but 7 arguments were supplied
  --> /Users/berkus/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koji-2.2.0/src/lib/commit.rs:44:15
   |
44 |     cocogitto.conventional_commit(
   |               ^^^^^^^^^^^^^^^^^^^
45 |         &commit_type,
   |         ------------ expected `CommitOptions<'_>`, found `&String`
   |
note: method defined here
  --> /Users/berkus/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cocogitto-6.1.0/src/command/commit.rs:24:12
   |
24 |     pub fn conventional_commit(&self, opts: CommitOptions) -> Result<()> {
   |            ^^^^^^^^^^^^^^^^^^^
help: remove the extra arguments
   |
45 -         &commit_type,
45 +         /* CommitOptions<'_> */,
   |

For more information about this error, try `rustc --explain E0061`.
error: could not compile `koji` (lib) due to 1 previous error

To Reproduce

cargo +nightly install koji

Expected behavior

Koji should install.

Additional context

Not sure when cocogitto changed this interface, but it seems like they broke API between 6.0 and 6.1. Koji should probably depend strictly on 6.0 or upgrade the dep to 6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant