-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE footer #86
Comments
This should be handled similarly to the scope and description prompt in my opinion. I'd like a conditional prompt appearing after confirming that there are breaking changes that asks me for a description of the breaking change, but allows me to just hit enter to skip adding the footer altogether. By the way, I recommend using It's also worth noting that how you currently handle the issue reference, it does not comply with git trailers either. Adding the here-proposed footer would break either its key or its value, depending on if the reference was on the line in front of or after the breaking change footer. In my understanding, there's two ways to mitigate this: Either keep the reference in the body part of the commit (like on the line after the description), or put the reference into a separate footer (such as |
The breaking change prompt currently adds the
!
symbol to the first line of the commit as expected.A BREAKING CHANGE footer is optional within the spec, and I wonder if this could also be included within the prompt. Though this might require a different behaviour from the relevant prompt,
The text was updated successfully, but these errors were encountered: