Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache scopes #39

Open
its-danny opened this issue Dec 29, 2021 · 0 comments
Open

cache scopes #39

its-danny opened this issue Dec 29, 2021 · 0 comments
Labels
enhancement New feature or request maybe Need to think on it

Comments

@its-danny
Copy link
Owner

its-danny commented Dec 29, 2021

config file needs to change to accept a scopes array. on first run (with --autocomplete), save the found scopes to the config via appending it. this allows the user to set up their own list when starting a fresh repo, while also populating it with new ones. every time you commit with koji, the list should be updated.

for this to work, commit_types needs to work differently. when we load a config, we need to check for commit_types and use the default if they don't exist. currently we only use the default if a config file doesn't exist at all.

this sounds like the correct thing to do, but i'm no totally sure it's necessary. autocomplete is an optional flag, and in a large repo it only slows startup down by milliseconds.

@its-danny its-danny added enhancement New feature or request maybe Need to think on it labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe Need to think on it
Projects
None yet
Development

No branches or pull requests

1 participant