Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected folder naming when providing s3 bucket as storage container #756

Open
LahiLuk opened this issue Jul 3, 2023 · 2 comments
Open

Comments

@LahiLuk
Copy link

LahiLuk commented Jul 3, 2023

I'm not entirely sure if this is a bug or a feature, but it would be good to know in order to be able to automate actions based on the expected output.

I'm using TPI and passing an AWS s3 bucket as the storage container, i.e.

storage {
    workdir = "src"
    container = "my-s3-bucket"
  }

Since I haven't specified any folder inside the bucket, I would expect that a folder with the task ID will be created, e.g., tpi-basically-fit-oryx-xjezxu77-5eudru0h. However, what happens is that a folder named just xjezxu775eudru0h is created, which is in contrast to all the other resources being named following the full task ID. Is this expected behavior?

@LahiLuk LahiLuk changed the title Unexpected bucket naming when providing container name Unexpected folder naming when providing s3 bucket as storage container Jul 3, 2023
@dacbd
Copy link
Contributor

dacbd commented Jul 6, 2023

@tasdomas do you have availability to take a look?

@0x2b3bfa0
Copy link
Member

Hello, @LahiLuk!

Probably long identifiers would be more adequate than short identifiers in this case. Unfortunately, when writing #687, user experience wasn't our topmost priority.

Feel free to open a pull request replacing .Short() with .Long() in all these places:

if task.RemoteStorage.Path == "" {
task.RemoteStorage.Path = t.Identifier.Short()
}

if task.RemoteStorage.Path == "" {
task.RemoteStorage.Path = t.Identifier.Short()
}

if task.RemoteStorage.Path == "" {
task.RemoteStorage.Path = t.Identifier.Short()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants