Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom type solution for GCP helper machine types #719

Open
dacbd opened this issue Nov 15, 2022 · 0 comments
Open

Custom type solution for GCP helper machine types #719

dacbd opened this issue Nov 15, 2022 · 0 comments
Labels
cloud-gcp Google Cloud technical-debt Refactoring, linting & tidying

Comments

@dacbd
Copy link
Contributor

dacbd commented Nov 15, 2022

Context: #718 (comment)

Culprit:

instanceTypes := make(map[string]map[string]map[string]string)
instanceTypes["m"] = map[string]map[string]string{
"accelerator": {
"count": "0",
"type": "",
},
"machine": {
"type": "e2-custom-8-32768",
},
}
instanceTypes["l"] = map[string]map[string]string{
"accelerator": {
"count": "0",
"type": "",
},
"machine": {
"type": "e2-custom-32-131072",
},
}
instanceTypes["xl"] = map[string]map[string]string{
"accelerator": {
"count": "0",
"type": "",
},
"machine": {
"type": "n2-custom-64-262144",
},
}
instanceTypes["m+k80"] = map[string]map[string]string{
"accelerator": {
"count": "1",
"type": "nvidia-tesla-k80",
},
"machine": {
"type": "custom-8-53248",
},
}
instanceTypes["l+k80"] = map[string]map[string]string{
"accelerator": {
"count": "4",
"type": "nvidia-tesla-k80",
},
"machine": {
"type": "custom-32-131072",
},
}
instanceTypes["xl+k80"] = map[string]map[string]string{
"accelerator": {
"count": "8",
"type": "nvidia-tesla-k80",
},
"machine": {
"type": "custom-64-212992-ext",
},
}
instanceTypes["m+v100"] = map[string]map[string]string{
"accelerator": {
"count": "1",
"type": "nvidia-tesla-v100",
},
"machine": {
"type": "custom-8-65536-ext",
},
}
instanceTypes["l+v100"] = map[string]map[string]string{
"accelerator": {
"count": "4",
"type": "nvidia-tesla-v100",
},
"machine": {
"type": "custom-32-262144-ext",
},
}
instanceTypes["xl+v100"] = map[string]map[string]string{
"accelerator": {
"count": "8",
"type": "nvidia-tesla-v100",
},
"machine": {
"type": "custom-64-524288-ext",
},
}

Ideally the solution is reuseable for parsing machine types for runner and task

@dacbd dacbd added technical-debt Refactoring, linting & tidying cloud-gcp Google Cloud labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-gcp Google Cloud technical-debt Refactoring, linting & tidying
Projects
None yet
Development

No branches or pull requests

1 participant