You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
we found that dvc metrics diff --alloutputs nothing, if a_revand b_rev refer to the same git commit. No matter if they are exactly the same or different types of references (HEAD vs branch_name, etc.)
Reproduce
setup any dvc stage with metrics.
run dvc metrics diff --all $(git rev-parse --abbrev-ref HEAD) HEAD
Expected
output metrics-diff table with all values with diff = 0.0
Running the debugger, we noticed that metrics/diff.py:diff expects the results of metrics.show() to have the exact rev keys extracted. However metrics/show.py:show uses the brancher to extract the revs to use.
However the brancher groups revs with the same sha and joins them.
This means that when we call dvc metrics diff --all main main the brancher would group main and main and return main,main.
Hence the repo.metrics.show() outputs all metrics with the key main,main and the repo.metrics.diff() doesn't find results for main
The text was updated successfully, but these errors were encountered:
@dberenbaum Thank you :) I'm interested in contributing a fix, but i have to admit it'll be my first one ever to an open source github project. I have a really nice colleague that is here to help any time if I need help or have questions, so fixing it should'nt be any problem. If I have any questions or updates about possible solutions, I'll add a comment to this thread!
Bug Report
Description
Hello,
we found that
dvc metrics diff --all
outputs nothing, ifa_rev
andb_rev
refer to the same git commit. No matter if they are exactly the same or different types of references (HEAD vs branch_name, etc.)Reproduce
dvc metrics diff --all $(git rev-parse --abbrev-ref HEAD) HEAD
Expected
output metrics-diff table with all values with diff = 0.0
Environment information
Output of
dvc doctor
:Additional Information (if any):
Running the debugger, we noticed that metrics/diff.py:diff expects the results of metrics.show() to have the exact rev keys extracted. However metrics/show.py:show uses the brancher to extract the revs to use.
However the brancher groups revs with the same sha and joins them.
This means that when we call
dvc metrics diff --all main main
the brancher would groupmain
andmain
and returnmain,main
.Hence the
repo.metrics.show()
outputs all metrics with the keymain,main
and therepo.metrics.diff()
doesn't find results formain
The text was updated successfully, but these errors were encountered: