Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dvc artifacts get --show-url #10423

Merged
merged 2 commits into from
May 23, 2024
Merged

add dvc artifacts get --show-url #10423

merged 2 commits into from
May 23, 2024

Conversation

dberenbaum
Copy link
Contributor

Closes #10420

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.60%. Comparing base (a7c0f6e) to head (a23367d).
Report is 1 commits behind head on main.

Files Patch % Lines
dvc/commands/artifacts.py 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10423      +/-   ##
==========================================
+ Coverage   90.50%   90.60%   +0.10%     
==========================================
  Files         502      502              
  Lines       38982    38992      +10     
  Branches     5622     5632      +10     
==========================================
+ Hits        35279    35329      +50     
+ Misses       3006     2991      -15     
+ Partials      697      672      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tibor-mach
Copy link
Contributor

This looks good... @dberenbaum does it need the remote git repo access or can it rely on the token? I think that either is fine for the moment but we should clarify that in the docs (since if it needs the repo access it behaves differently than other uses of dvc artifacts get

@tibor-mach
Copy link
Contributor

Can this be merged now?

@dberenbaum dberenbaum enabled auto-merge (rebase) May 23, 2024 16:25
@dberenbaum dberenbaum merged commit 05db79e into main May 23, 2024
19 checks passed
@dberenbaum dberenbaum deleted the arts-get-url branch May 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature proposal: dvc artifacts get --show-url
3 participants