Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema/Object types #76

Open
dacbd opened this issue Aug 20, 2023 · 2 comments
Open

Schema/Object types #76

dacbd opened this issue Aug 20, 2023 · 2 comments

Comments

@dacbd
Copy link
Contributor

dacbd commented Aug 20, 2023

@daavoo do you or the DVC team have any strong feelings about using pydantic over voluptuous? I think it has better support for clearer type-hinting / IntelliSense

@daavoo
Copy link
Contributor

daavoo commented Aug 21, 2023

@daavoo do you or the DVC team have any strong feelings about using pydantic over voluptuous? I think it has better support for clearer type-hinting / IntelliSense

I prefer pydantic. The reason I used voluptuous is that it is already a dependency in DVC, to avoid introducing a new dependency

@dacbd
Copy link
Contributor Author

dacbd commented Aug 21, 2023

gto does and is being added to DVC, after that is complete I'd like to PR this and DVC to use pydantic over voluptuous.

Do you foresee any issues with that? cc @iterative/dvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants