Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crochet's shutdown strategy is problematic #79

Open
itamarst opened this issue Feb 24, 2015 · 1 comment
Open

Crochet's shutdown strategy is problematic #79

itamarst opened this issue Feb 24, 2015 · 1 comment

Comments

@itamarst
Copy link
Owner

  1. A thread named MainThread doesn't always exist (see fix crochet crashing when MainThread isn't available when _shutdown module is loaded #69, some comments crochet doesn’t work with uWSGI #78).
  2. Shutting down when the main thread exits may be the wrong thing to do; perhaps the main thread starts a thread pool of workers and then exits.

Perhaps it would be better to just set all the crochet threads to be daemon threads.
Downsides:

  1. No reactor shutdown events.
  2. An occasional segfault? Though maybe modern Python is better than that.
@itamarst
Copy link
Owner Author

Combination of #83 and #81 are going to fix this, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant