New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors when .sh script run with shim #10
Comments
@addaleax any thoughts about this old issue that's open on |
@bcoe I’d love to help, but the branches mentioned the issue are gone, and it appears quite a bit has happened in the semantic-release since the original report… do you have some kind of working reproduction without it? Or maybe the git SHAs from back then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I finally dug into the problem that @boennemann is seeing here:
istanbuljs/nyc#34
tldr; this script fails when instrumented with spawn-wrap's shim:
https://github.com/semantic-release/semantic-release/blob/caribou/test/registry/start.sh
The logic that is causing the script to fail relates to paths being remapped to point to the spawn-wrap shim:
One Possible Solution
I managed to instrument
semantic-release
's integration tests withnyc
, by simply ignore the shell script that was causing issues:I wonder if we should just have
spawn-wrap
accept a list of files to ignore? This might be a good way to help people get around edge-cases.A Better Solution
@isaacs any idea why remapping the
/^PATH=/
is causing trouble for this script in particular?The text was updated successfully, but these errors were encountered: