Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missing] Homepage link to the Navbar Logo ! #99

Open
icoderharshit opened this issue Oct 2, 2020 · 7 comments
Open

[Missing] Homepage link to the Navbar Logo ! #99

icoderharshit opened this issue Oct 2, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that'll help you in your first time contribution to the open source community. ;) hacktoberfest-accepted

Comments

@icoderharshit
Copy link
Contributor

icoderharshit commented Oct 2, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I think, homepage link which is missing in the Navbar logo is something that catches eye(atleast once) , Isn't it ?
Describe the solution you'd like
Addition of an anchor tag around the Navbar logo, simple as it sounds.

@ishandeveloper

@ibhavikamalhotra
Copy link

I want to add this and make a PR real quick.

@ishandeveloper
Copy link
Owner

@icoderharshit Thanks for taking out the time to find this issue.

Let me know if you'd like to work on this issue, if yes, then I'll assign this issue to you, else I can assign this to @ibhavikamalhotra and she can work on this!

@ishandeveloper ishandeveloper added enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that'll help you in your first time contribution to the open source community. ;) labels Oct 2, 2020
@icoderharshit
Copy link
Contributor Author

Assign this to @ibhavikamalhotra , and check out my PR @ishandeveloper

@ibhavikamalhotra
Copy link

Alright , @icoderharshit .

@ishandeveloper
Copy link
Owner

ishandeveloper commented Oct 2, 2020

Sure, @icoderharshit . I'll be reviewing most of the PRs later today by the night.

@ibhavikamalhotra I've assigned this issue to you, Go ahead and make a PR. Goodluck ! 🎊

@roshankcjha
Copy link

@ishandeveloper do check out #200 it might contain a possible solution for this problem and provide your reviews.

@ydegtyar
Copy link

ydegtyar commented Oct 27, 2020

Fixed this issue at pull request #216. Check is failed because of Docker.
image
Please review it, merge, give feedback, approve or put hacktoberfest-accepted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that'll help you in your first time contribution to the open source community. ;) hacktoberfest-accepted
Projects
None yet
Development

No branches or pull requests

5 participants