-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding params to the requests #3
Comments
Yeah, that sounds like a useful PR. I'd merge that. If params is
Anything I'm missing? Tests and documentation are always appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've begun integrating this into our project as it looks like a promising way to cut down repetition for requests (of which there are a considerable amount). One small thing I ran into however was adding params to the requests -- which we do for almost all requests -- which now has to be done with string concatenation. This feels fairly clunky compared to e.g.
@angular/http/common
which allows passing a map of the params.What is your opinion on providing a optional key
params
to theRequestParam
type? If you are interested I can see if I can make a PR.The text was updated successfully, but these errors were encountered: