Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use zmq.PROBE_ROUTER to register connections to schedulers #476

Open
minrk opened this issue Jun 8, 2021 · 1 comment
Open

use zmq.PROBE_ROUTER to register connections to schedulers #476

minrk opened this issue Jun 8, 2021 · 1 comment

Comments

@minrk
Copy link
Member

minrk commented Jun 8, 2021

There is a race where engine connections to schedulers takes a finite amount of time, and it is possible for clients to be informed of an engine's registration before the engine is fully connected to all schedulers.

The current registration design effectively assumes heartbeats will complete after registration is complete, but the faster launch-then-use nature of the cluster Python API reveals the race.

Using the zmq.ROUTER_PROBE should allow us to delay registration notification until all probe messages have been received by the schedulers.

@minrk
Copy link
Member Author

minrk commented Jul 7, 2021

This should be not only more rigorous, but faster because we can wait for the actual event: everything is connected, rather than needing to set a long heartbeat and/or registration timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant