Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The iopipe_handlers modules not included in package when exclude/include used #83

Open
kolanos opened this issue Jul 24, 2018 · 1 comment

Comments

@kolanos
Copy link

kolanos commented Jul 24, 2018

Description

If you use exclude and include in the package section of the serverless.yml then the iopipe_handlers modules can be excluded from the resulting package, resulting in a "could not find module" error.

Steps to reproduce the issue:

  1. Update a serverless.yml with something like this:
package:
  exclude:
    - ./**
  include:
    - dist/**
  1. sls deploy
  2. Notice that invocations fail with a "could not find iopipe_handlers/..." error.

Describe the results you received:

Handlers return errors reporting that they can't find the respective iopipe_handlers module.

Describe the results you expected:

Expected iopipe_handlers modules to be packaged regardless of exclude/include rules.

Application and library versions

Tested with serverless 1.28.0 and latest version of plugin.

Additional information you deem important (e.g. issue happens only occasionally):

@ktwbc
Copy link

ktwbc commented Mar 21, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants