Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node.js streams for profile data transport #16

Open
coreylight opened this issue Nov 10, 2017 · 1 comment
Open

Use node.js streams for profile data transport #16

coreylight opened this issue Nov 10, 2017 · 1 comment

Comments

@coreylight
Copy link
Contributor

We are currently using a string that will take up memory inside of the lambda
https://github.com/iopipe/iopipe-plugin-profiler/blob/master/src/index.js#L80

We can use the stream instead, example here:
https://github.com/node-inspector/v8-profiler

To stream directly to the http request. Saving memory and potentially time.

@pselle
Copy link
Contributor

pselle commented Nov 24, 2017

Making a note here that this might be useful: https://github.com/substack/hyperquest. The current approach of using stdlib https looks like it might cause pain/there are known issues with trying to stream data without fine-tuning

@pselle pselle self-assigned this Nov 27, 2017
@pselle pselle removed their assignment Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants