Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ionic/react-router not compatible with latest version of ERROR in ./node_modules/@ionic/react-router/dist/index.js 890:18-28 export 'withRouter' (imported as 'withRouter') was not found in 'react-router-dom #29415

Closed
3 tasks done
superm123 opened this issue Apr 29, 2024 · 6 comments
Assignees
Labels

Comments

@superm123
Copy link

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

When upgrading getting the following error message:
ERROR in ./node_modules/@ionic/react-router/dist/index.js 890:18-28
export 'withRouter' (imported as 'withRouter') was not found in 'react-router-dom' (possible exports: AbortedDeferredError, Await, BrowserRouter, Form, HashRouter, Link, MemoryRouter, NavLink, Navigate, NavigationType, Outlet, Route, Router, RouterProvider, Routes, ScrollRestoration, UNSAFE_DataRouterContext, UNSAFE_DataRouterStateContext, UNSAFE_ErrorResponseImpl, UNSAFE_FetchersContext, UNSAFE_LocationContext, UNSAFE_NavigationContext, UNSAFE_RouteContext, UNSAFE_ViewTransitionContext, UNSAFE_useRouteId, UNSAFE_useScrollRestoration, createBrowserRouter, createHashRouter, createMemoryRouter, createPath, createRoutesFromChildren, createRoutesFromElements, createSearchParams, defer, generatePath, isRouteErrorResponse, json, matchPath, matchRoutes, parsePath, redirect, redirectDocument, renderMatches, resolvePath, unstable_HistoryRouter, unstable_usePrompt, unstable_useViewTransitionState, useActionData, useAsyncError, useAsyncValue, useBeforeUnload, useBlocker, useFetcher, useFetchers, useFormAction, useHref, useInRouterContext, useLinkClickHandler, useLoaderData, useLocation, useMatch, useMatches, useNavigate, useNavigation, useNavigationType, useOutlet, useOutletContext, useParams, useResolvedPath, useRevalidator, useRouteError, useRouteLoaderData, useRoutes, useSearchParams, useSubmit)

Expected Behavior

Work with no probs

Steps to Reproduce

Upgrade to react 18

Code Reproduction URL

https://github.com/superm123/fjm

Ionic Info

Using latest ionic props
package.json

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Can you make your repo public?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Apr 29, 2024
@ionitron-bot ionitron-bot bot removed the triage label Apr 29, 2024
@superm123
Copy link
Author

superm123 commented Apr 29, 2024 via email

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Apr 29, 2024
@liamdebeasi
Copy link
Contributor

Can you make the repo public so the entire team has access? The reproduction case should contain only the code required to reproduce the issue, and any secret code should be removed.

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Apr 30, 2024
@ionitron-bot ionitron-bot bot removed the triage label Apr 30, 2024
@emitategh
Copy link

I'm facing the same issue, any news?

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels May 14, 2024
@superm123
Copy link
Author

superm123 commented May 14, 2024 via email

@brandyscarney
Copy link
Member

Hello, @ionic/react-router is not compatible with React Router 6. There is an open issue for this if you'd like to subscribe to it for updates: #24177

If you are running into issues using @ionic/react-router with React Router 5, please open a new issue with a minimal reproduction that we can use to reproduce the issue. Thank you!

@brandyscarney brandyscarney closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants