Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #212

Open
RobertCraigie opened this issue Jan 16, 2022 · 2 comments
Open

Add type annotations #212

RobertCraigie opened this issue Jan 16, 2022 · 2 comments

Comments

@RobertCraigie
Copy link

RobertCraigie commented Jan 16, 2022

Type annotations would improve the editor experience and support static type checking. Type annotations would only really have to be added to user facing code but it would still be beneficial to type the whole codebase as well.

I'd be happy to help with this if it is deemed acceptable :)

@LewisGaul
Copy link

I think the only thing needed to allow users to annotate their code is to expose the BenchmarkFixture class from __init__.py?

@RobertCraigie
Copy link
Author

Potentially. A py.typed file would have to be added as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants