Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asv (airspeed-velocity) integration #208

Open
FFY00 opened this issue Jul 11, 2021 · 2 comments
Open

asv (airspeed-velocity) integration #208

FFY00 opened this issue Jul 11, 2021 · 2 comments

Comments

@FFY00
Copy link

FFY00 commented Jul 11, 2021

asv is a project that can run benchmarks and create a nice website with the results and comparisons to previous versions. I would be really nice if it was possible to use pytest-benchmark as the data provider, as it has a nicer API to write tests and is integrated with pytest.

One option would be to add support directly to pytest-benchmark, but this adds more weight for the maintainers and would maybe be better as a separate plugin.

#200 would allow us to more easily implement this, but for the time being, I was thinking about hijacking pytest_benchmark_generate_json to additionally generate the asv output. What do you think?

An asv plugin would need the following:

  • A way to fetch the benchmark data, so that it can generate the asv output
  • A way to customize the commit information (pytest_benchmark_generate_commit_info), because we may be running benchmarks for an external project and want to track its version/commit
@astrojuanlu
Copy link
Contributor

@FFY00 Did you end up hacking something? There's a symmetric proposal at airspeed-velocity/asv#567

@FFY00
Copy link
Author

FFY00 commented Jan 25, 2022

I did not 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants