Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an image cache in section 3.4 #90

Closed
wants to merge 1 commit into from

Conversation

NiklasEi
Copy link

Introduce an image cache in section 3.4 after batch rendering.

Resolves #89

@NiklasEi
Copy link
Author

NiklasEi commented Sep 30, 2020

Should I propagate my code changes to 3.5 and 4.1? I am not sure what else changed since there are no chapters for those versions yet.

I have one issue with the updated chapter 3.4. One of the code examples during the implementation of batch rendering will give users an error since it includes code changes from the image caching (last code block in batch rendering includes a call to #load_image). Not sure how to resolve that one.

@NiklasEi
Copy link
Author

What do you think about adding the cache in a separate small chapter? I can't find a way to not have an influence on the code examples in batch rendering.
If it should stay in the same chapter I could also create my own code directory for the image cache part of the chapter.

@iolivia
Copy link
Owner

iolivia commented Mar 20, 2021

@NiklasEi I think it would be a great idea to add this as a separate section to the last chapter, maybe after batch rendering. what do you think?

@NiklasEi
Copy link
Author

@NiklasEi I think it would be a great idea to add this as a separate section to the last chapter, maybe after batch rendering. what do you think?

So just like the current code changes?
The issue in my second comment is still not resolved though.

@NiklasEi NiklasEi closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further performace improvements for rendering (image caching)
2 participants