Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package com.intuit.ipp.core between java-devkit and java-data #121

Open
plcarmel opened this issue Feb 13, 2020 · 11 comments
Open

Split package com.intuit.ipp.core between java-devkit and java-data #121

plcarmel opened this issue Feb 13, 2020 · 11 comments

Comments

@plcarmel
Copy link

It makes it impossible to include both of those maven dependencies directly (i.e.e without some form of repackaging) in a Java 9 modules.

@diana-derose
Copy link
Collaborator

hey @plcarmel - I have added a story in our backlog to address this. Here's the internal jira id IDG-3475 for reference. We'll try to scope this work in our upcoming sprints. If you would like to contribute a fix for this, please send across a PR.

@rachanamamillapalli
Copy link

Hi @fjolin-intuit, I would like to work on this

@rachanamamillapalli
Copy link

rachanamamillapalli commented Sep 29, 2020

@diana-derose / @plcarmel Is this still needed or some work is already going one?

@plcarmel
Copy link
Author

@rachanamamillapalli, that would be appreciated.

@fjolin-intuit
Copy link
Collaborator

@rachanamamillapalli This is still needed - your contribution is welcomed :)

@ashking94
Copy link

@plcarmel @rachanamamillapalli is this being looked upon? I wanted to understand the issue and take a stab onto fixing this over the weekend.

@plcarmel
Copy link
Author

plcarmel commented Oct 9, 2020

@ashking94, not by me.

@rachanamamillapalli
Copy link

@fjolin-intuit @plcarmel @diana-derose Could you take a look at the PR linked to this issue.

@fjolin-intuit
Copy link
Collaborator

@rachanamamillapalli I spent some time looking at this - it would introduce some breaking changes which is ok as long as we version the release and put communication out beforehand. Were you able to test this PR against a sample? I tried this and couldn't get the dependencies to work out - I think it might be because the all project that was introduce is a generator pom instead of creating jars. I wasn't able to figure out how to import ipp-v3-java-all into my project. If you could try this in a sample to show how converting is done - we could create better communication around this change and I could bump up a major version change.

@rachanamamillapalli
Copy link

@fjolin-intuit I haven't tested it on sample yet. Will try importing and update once I make any progress.

@othenos
Copy link

othenos commented Aug 30, 2021

Is there any workaround for this problem? module XXX reads package com.intuit.ipp.core from both ipp.v3.java.devkit and ipp.v3.java.data I cannot seem to find an answer anywhere. There must be some developers who have moved beyond Java 8 and circumvented this somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants