-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interchange use of AppName-x and AppName in the launcher #73
Comments
sanbee
pushed a commit
to sanbee/exodus_sbfork
that referenced
this issue
Jul 3, 2023
Seems to fix the problem reported in intoli#73.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am not reporting an issue. This is a request for a change.
I am using exodus on a Linux distribution.
Assuming the name of the application ins AppName, the exodus launcher creates a symlink to a shell script with the same name inside the bundle directory. The actual binary is renamed to AppName-x and the AppName script launchies AppName-x.
When the application use the name of the binary for internal use, this creates a problem for applications that load their setup from a file name derived from AppName. Existing setup files (e.g. name "AppName.def") need to also be renamed now to AppName-x.def when the application is launched from exodus launcher.
It will be helpful if the exodus code can be modified to flip the use of AppName-x and AppName script. I.e., AppName-x becomes the launcher script and keep the name of the actual binary as AppName. The top-level symlink then points to AppName-x in the bundle directory which will launch AppName and the above problem disappears.
I have tested this scheme on a simple bundle (with the launcher script being a bash script in Linux) by making these modifications by-hand. I have played around with modifying the code in bundling.py to achieve this, but without full success. I am also not sure if I understand the code well enough to ensure that my changes would cover all use cases. I would therefore appreciate that, if this makes sense and does not break anything, someone more knowledgeable make the necessary modifications. Alternatively, if someone can tell what to do I'll make any attempt myself. Thanks.
The text was updated successfully, but these errors were encountered: