Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we remove the "in English" link from the editions list on a work page? #9253

Open
RayBB opened this issue May 10, 2024 · 5 comments
Open

Can we remove the "in English" link from the editions list on a work page? #9253

RayBB opened this issue May 10, 2024 · 5 comments
Assignees
@jainish2222
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 10, 2024

Having the link that just goes to this page (https://openlibrary.org/languages/eng) and is not useful to patrons as far as I can tell.

Describe the problem that you'd like solved

image

Proposal & Constraints

I think we should convert it to plain text instead of a hyperlink.

Additional context

Stakeholders
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 10, 2024
@stopregionblocking
Copy link

Doesn't this display for every language, not just english? Maybe there's a different function it could be changed to that would be beneficial across languages.

@RayBB
Copy link
Collaborator Author

RayBB commented May 10, 2024

@stopregionblocking it does show for every language. What function do you propose changing it to?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 11, 2024
@mekarpeles
Copy link
Member

I think we just want to remove the link around the language -- not the language text itself. This change seems fine (+1 @mekarpeles , @jimchamp , @scottbarnes )

@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Good First Issue Easy issue. Good for newcomers. [managed] Affects: Experience Issues relating directly to service design & patrons experience and removed Needs: Lead Needs: Response Issues which require feedback from lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels May 13, 2024
@jainish2222
Copy link

Hello! Could I please work on this issue?

@RayBB
Copy link
Collaborator Author

RayBB commented May 20, 2024

@jainish2222 yes you're assigned. Good luck!

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 21, 2024
@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainish2222 jainish2222

Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RayBB @mekarpeles @stopregionblocking @jainish2222