Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add real-time validation for emails/screennames taken on IA to prevent random digit appending #7080

Closed
Tracked by #2055
seabelis opened this issue Oct 13, 2022 · 3 comments · Fixed by #9223
Closed
Tracked by #2055

Add real-time validation for emails/screennames taken on IA to prevent random digit appending #7080

seabelis opened this issue Oct 13, 2022 · 3 comments · Fixed by #9223
Assignees
@rebecca-shoptaw
Labels
Affects: Experience Issues relating directly to service design & patrons experience Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 2 Important, as time permits. [managed] registration Type: Bug Something isn't working. [managed]
Milestone
2024 (provisional...

Comments

@seabelis
Copy link
Collaborator

Patron reports that their chosen username was appended with numbers. The patron was not informed that this would happen during registration and understood the chosen username was available.

Evidence / Screenshot (if possible)

Relevant url?

Steps to Reproduce

According to @mekarpeles , this happens when the archive.org ID they request is available but the open Library ID is not.

  • Actual: No warning that the chosen username is not available and will be appended
  • Expected: If chosen username is not available warn the patron and give the opportunity to choose a different name.

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@mekarpeles
@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Experience Issues relating directly to service design & patrons experience Needs: Lead labels Oct 13, 2022
@happycoding47
Copy link

Hi @seabelis, I'd like to help solve this issue if it's still open. Please guide. Thanks!

@seabelis
Copy link
Collaborator Author

Perhaps @mekarpeles can provide some guidance on this?

@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 14, 2022
@mekarpeles mekarpeles added this to the Next (proposed) milestone Nov 14, 2022
@mekarpeles
Copy link
Member

@happycoding47 if you'd like to take a look at the code in openlibrary/account/model.py you should be able to see where this logic is being done within the audit function. See if you can propose a better way of doing this!

@mekarpeles mekarpeles modified the milestones: Next (proposed), 2023 Jan 26, 2023
@mekarpeles mekarpeles modified the milestones: 2023, Sprint 2023-12 Nov 6, 2023
@mekarpeles mekarpeles mentioned this issue Apr 26, 2024
Open
7 tasks
@rebecca-shoptaw rebecca-shoptaw mentioned this issue Apr 30, 2024
Closed
21 tasks
@rebecca-shoptaw rebecca-shoptaw changed the title Usernames appended upon registration without notification Add validation for emails/screennames taken on IA to prevent random digit appending May 1, 2024
@rebecca-shoptaw rebecca-shoptaw changed the title Add validation for emails/screennames taken on IA to prevent random digit appending Add real-time validation for emails/screennames taken on IA to prevent random digit appending May 1, 2024
This was referenced May 1, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebecca-shoptaw rebecca-shoptaw

Labels
Affects: Experience Issues relating directly to service design & patrons experience Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 2 Important, as time permits. [managed] registration Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
2024 (provisional, requires discussion)
Development

Successfully merging a pull request may close this issue.

Add pre-registration validation for IA email and username rebecca-shoptaw/openlibrary
5 participants
@mekarpeles @seabelis @jimchamp @happycoding47 @rebecca-shoptaw