Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ruff rule: unnecessary-placeholder (PIE790) #9183

Open
RayBB opened this issue Apr 29, 2024 · 1 comment
Open

enable ruff rule: unnecessary-placeholder (PIE790) #9183

RayBB opened this issue Apr 29, 2024 · 1 comment
Labels
Affects: Developers Affects: Documentation Issues related to developer or ops or data documentation. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 3 Issues that we can consider at our leisure. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Apr 29, 2024 •
edited

Problem

Is is on by default for ruff but we have it disabled.
Is there a reason why? If not, it is auto-fixable with ruff and we have 12 instances of it in our code.

The benefit is cleaner/less code and possibly finding a few functions we can delete.

Evidence / Screenshot

Relevant URL(s)

https://docs.astral.sh/ruff/rules/unnecessary-placeholder/

openlibrary/pyproject.toml

Line 52 in 01d693d

"PIE790",

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Apr 29, 2024
@RayBB RayBB changed the title enable ruff unnecessary-placeholdert (PIE790) rule enable ruff rule: unnecessary-placeholdert (PIE790) Apr 29, 2024
@mekarpeles mekarpeles added Lead: @scottbarnes Issues overseen by Scott (Community Imports) and removed Needs: Lead labels Apr 29, 2024
@RayBB RayBB changed the title enable ruff rule: unnecessary-placeholdert (PIE790) enable ruff rule: unnecessary-placeholder (PIE790) Apr 29, 2024
@scottbarnes
Copy link
Collaborator

For my part I am indifferent to this one, but I can see how people might have opinions on it. If there is a specific reason it's disabled, that reason is unknown to me.

@scottbarnes scottbarnes added Priority: 3 Issues that we can consider at our leisure. [managed] Affects: Documentation Issues related to developer or ops or data documentation. [managed] Affects: Developers and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Developers Affects: Documentation Issues related to developer or ops or data documentation. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 3 Issues that we can consider at our leisure. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RayBB @mekarpeles @scottbarnes