-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify style of search buttons #9086
Comments
I'd like to work on this! |
@0simoo I've assigned you. Feel free to create a proof of concept that you think looks nice and we can discuss further from there. |
@0simoo I like both of them a lot actually. A small personal preference for the 2nd one but both would be a great improvement. If not, I'll try to share and see what people say! |
I should be able to attend today's community call! |
Thanks @0simoo! As discussed during today's community call:
|
Any changes that you make to a More information about this can be found here. |
I've made a pull request with the new designs. Let me know what you think! @jimchamp |
After decision today during design call, we'd like to move forward with a very similar design, inspired by what we already use in the header: Instead of having "Search" be a button to the right of the input, we'll have a magnifying glass be the button within the input area. Finally, we'd like to re-use this paradigm / component as a template for:
For now, we've decided that this template should be different that the one in the header navigation to keep things simple. cc: @0simoo Also, just to be clear, we're not asking for all of these changes in 1 PR, for now, this PR can be closed when we have a template that achieves the design in this comment and it's being applied to the various search pages. |
So I should change the designs to the magnifying glass one? I think I'm bit confused about what you mean by the template should be different than the one in the header. |
@0simoo what he means is In that file put (or whatever it is): In As for the other comment:
^ This just means don't try to reuse the search bar we currently have here openlibrary/openlibrary/templates/lib/nav_head.html Lines 98 to 111 in 37db01e
|
I've made a commit to the PR. Let me know if there's anything I misunderstood or should fix! |
Following #8963 we want to evaluate unifying the styles of the search buttons with something like
cta-btn cta-btn--small cta-btn--vanilla
etc.This will potentially also require changing the text input to match the height and look nice. Maybe like the button group from bootstrap here.
Describe the problem that you'd like solved
Proposal & Constraints
Additional context
Stakeholders
The text was updated successfully, but these errors were encountered: