Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize batch functions that apply configuration from manifest where applicable in interbit package #657

Open
nicholeous opened this issue Aug 21, 2018 · 0 comments
Assignees
Labels
deploy sdk-cli SDK - Command Line Interface untidy! untidy! Ideal candidate for tidy Friday cleanup.

Comments

@nicholeous
Copy link
Contributor

Use Promise.all to ensure all configuration changes are applied before returning from function to ensure functionality is complete prior to exit while still paralellizing the calls making the changes

See

  • applyCovenant in configureChains.js
  • tryConnect in configurePeers.js
  • deployCovenant in createChains.js
  • try/catch performing cli.loadChain and cli.startChain in createChains.js
  • deployCovenant in deployCovenants.js
@nicholeous nicholeous self-assigned this Aug 21, 2018
@nicholeous nicholeous added sdk-cli SDK - Command Line Interface untidy! untidy! Ideal candidate for tidy Friday cleanup. labels Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy sdk-cli SDK - Command Line Interface untidy! untidy! Ideal candidate for tidy Friday cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants