-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in CI #38
Comments
To run lit tests just build "gc-check" cmake --build . --target gc-check Currently it's just a stub - we don't have passes and correct use-cases to run lits. |
Shall we let llvm-lit to drive all of the tests including gtest? I have enabled a MLIR-related unittest at #44 |
@Devjiu
probably llvm should be rebuilt to add |
This pr added llvm-lit into build: https://github.com/intel/graph-compiler/pull/39/files another way is to install lit in pip, but I recommend use the same lit as it was in llvm. |
What benefit does it bring? |
It provides a unified entry of all tests, as done in LLVM project. Most (all?) FileCheck/Python/Gtest are driven by Another benefit is that, we can reuse the gtest headers and static libraries exported by LLVM, and we don't need to manage gtest as a 3rdparty on our own. We can use the cmake function |
Currently we also need gtests that test the oneDNN API integration. If in this case everything works fine, we can consider it; if not, then the idea of a common runner for all tests does not work and a different structure needs to be discussed. We will also need integration tests that run the pipeline starting from the pytorch model, which can also be inconvenient to embed in cmake. It seems to me that we will have several test runners in any case, since there is a need for different types of testing. In general, such functionality at the current stage is simply a matter of taste. |
OK, sure! But I would suggest to drive all unittests directly testing MLIR with lit. I mean the C++ tests for the MLIR components. As it matches the MLIR upstream's way and makes it easier to upstream. |
@kurapov-peter should I add more tests to CI? |
-DGC_TEST_ENABLE=on
. Currently, there's only one built now, run ascd test/dnnl/ && ./test_dnnl_c_interface
. I think it's missing aenable_testing
now for ctest. Feel free to add that or a separate target.The text was updated successfully, but these errors were encountered: