-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type distribution vs parameter distribution format #333
Comments
Yes this has bothered me
the natural shape would be as a data.frame with rows for draws
I think there's an internal use where we use the transpose
…On Fri 22. Mar 2024 at 20:37, Till Tietz ***@***.***> wrote:
@macartan <https://github.com/macartan>
I just noticed that we export the transpose of posterior / prior
distributions over causal types from get_type_prob_multiple (i.e. causal
types ares rows and draws are columns) while the causal type posterior in
stan_objects as well as distributions over parameters have the draws in
rows.
Is there any particular reason for this? I didn't want to change anything
to avoid introducing breaking changes in downstream functions.
—
Reply to this email directly, view it on GitHub
<#333>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBE57IH7A35IA5DGHAXB53YZSCALAVCNFSM6AAAAABFD4ICLKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDGMJYHA2DANQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@macartan
I just noticed that we export the transpose of posterior / prior distributions over causal types from
get_type_prob_multiple
(i.e. causal types ares rows and draws are columns) while the causal type posterior in stan_objects as well as distributions over parameters have the draws in rows.Is there any particular reason for this? I didn't want to change anything to avoid introducing breaking changes in downstream functions.
The text was updated successfully, but these errors were encountered: