Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createKey type error when key consist of only digits #347

Open
judip opened this issue Mar 28, 2022 · 1 comment
Open

createKey type error when key consist of only digits #347

judip opened this issue Mar 28, 2022 · 1 comment

Comments

@judip
Copy link

judip commented Mar 28, 2022

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Branch? master

In function createKey() in file Importer.php (line 582) should be convert to string:
return (string) $this->expressionLanguage->evaluate(substr($definition->getKey(), 1), $data);

When key consist of only digits is problem because key is not string, but function return type string.

@dkarlovi dkarlovi added the bug label Apr 12, 2022
@dpfaffenbauer
Copy link
Collaborator

please create a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants