Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When addind masked-input to my application, the scrollTo() functions bugg. #135

Open
Hocoh opened this issue Apr 20, 2020 · 0 comments
Open

Comments

@Hocoh
Copy link

Hocoh commented Apr 20, 2020

When addind masked-input to my application, the scrollTo() functions bugg. Browser: Mozilla Firefox 68.7.0esr on Linux Debian 10 Buster.

Here the repository that reproduce my case: https://github.com/Hocoh/masked-input-is-makes-scrollTo-function-buggs

You will see that when masked-input is on the page to scroll at the page's top while rendering the next step cause bugg to occurs on the scrollTo's function.

Possibly other scroll API's functions bugg also.

Here a react snippet of the implementation:

`goNextStep=()=>{
let updateCurrentStep;

	let {currentStep}=this.state; 
	currentStep = currentStep >= 1? 1: currentStep+1;
	

	//setTimeout(()=>{
		this.setState(currentState=>{
			console.log("currentState.currentStep: ", currentState.currentStep)
			updateCurrentStep=currentState.currentStep;
			console.log("before modification => updateCurrentStep: ",updateCurrentStep)
			updateCurrentStep= updateCurrentStep >= 2? 2: updateCurrentStep+=1;
			console.log("after modification => updateCurrentStep: ",updateCurrentStep)
			return({
					currentStep:updateCurrentStep,
					isInputFocus:false
			})
			}, this.FormRef.current.scrollTo(0,0)
		)
	// },10)
		
}

goToPrecedingStep=()=>{
	let currentStep=this.state.currentStep;
	currentStep=currentStep<=0?0:currentStep-1;
	this.setState({
			currentStep,
			isInputFocus:false
		},
		() => this.FormRef.current.scrollTo(0,0)
	)
}

render() { 

	let {
		FormRef
	}=this

	let {
		currentStep
	}=this.state


	let previousButton=() =>{
		let{currentStep}=this.state
		return (
			<button 
				className={style["form__go-to-preceding-step-button"]}
				// className={style["form__go-to-preceding-step-button"]}
				type="button"
				onClick={this.goToPrecedingStep}
			>
				Previous step
			</button>
		)
	}			
	let nextButton =() => {
		let{currentStep}=this.state
		return(
			<button
				className={style["form__prepare-go-to-next-step-button"]}
				type="button"
				onClick={this.goNextStep}
			>
				Next step
			</button>
		)
	}


	return (
		<div ref={FormRef}  className={style["mobile-form"]} >				
			
			<form onSubmit={this.handleSubmit} className={style["caterer-call-to-action-form"]} >
			<div className={style["form__function-container"]}>
				<p className={style["form__step-number"]} >Step {currentStep +1}/3</p>
			</div>
				<FirstStep
					currentStep={currentStep}
				/>
				<SecondStep
					currentStep={currentStep}
				/>
				<ThirdStep
					currentStep={currentStep}
				/>

				<div className={style["form__step-button-container"]}	>
					{ 
						currentStep>0 &&
						previousButton()
					}
					{ 
						currentStep<4&&
						nextButton()
					}
				</div>
			</form>
			
		</div>
	);
}

}

const FirstStep= (props)=>{
if(props.currentStep!==0) return null

return ( 
	<div className={style["form__introduction_sequence"]}>
		<div className={style["content"]}/>
		
		<MaskedInput 
			mask="11-11-1111" 
		/>	
	</div>
)

}

const SecondStep=(props)=>{
if(props.currentStep!==1) return null
return <div className={style["content"]}/>
}

const ThirdStep=(props)=>{
if(props.currentStep!==2) return null
return <div className={style["content"]}/>
}
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant