-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: V3 question and possible documention improvements #15
Comments
The That is a recommendation, the package does not realy on
That is not necessarity true. The So, if inside We should consider documenting it, yes. Things that needs to happen on "init" might be called directly inside modules' Also consider there's a pretty extensive documentation on the workflow that the App bootting workflow, see https://github.com/inpsyde/wp-app-container/tree/3.x#providers-workflow. But all documentation should be revisited and split in shorter chapters in
As said above, the first thing to do will probably split exisiting documentation in chapers in a And yes, the specifics of v3 are mostly missing from current README because currently it is mostly a copy from v2 documentation with some (but not all) needed adjustments. |
Is your feature request related to a problem?
Not so much a problem, more of a collection of question/suggestions after having tested upgrading/migrating a project over to the v3 of wp-app-container.
Describe the desired solution
Answer questions and evaluate suggestions if they make sense for a future improvement day.
Describe the alternatives that you have considered
Additional context
Questions:
App\App
class?Currently there are 2 ways:
app()
andApp::new()
, with the latter only creating the object but the former actually storing the instance created.ExecutableModule
that registers a action oninit
, the registered action will never run.This is caused because the default for the
AppStatus::$lastStepHook
is init.We should consider clarifying this difference from how Modularity normally executes these modules in the docs.
Possible documentation improvement tasks:
App::addPackage
v.s.App::addProvidersPackage
)Code of Conduct
The text was updated successfully, but these errors were encountered: