Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR and Issue template #19

Closed
wants to merge 2 commits into from
Closed

Add PR and Issue template #19

wants to merge 2 commits into from

Conversation

reetasingh
Copy link

@reetasingh reetasingh commented Aug 26, 2021 •
edited

Fixes : #16
Used the templates from https://github.com/inlets/cloud-provision repo

@derek
Copy link

derek bot commented Aug 26, 2021

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the invalid This doesn't seem right label Aug 26, 2021
alexellis
alexellis reviewed Aug 26, 2021
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
* cloud-provision version


* Kubernetes distribution i.e. minikube v0.29.0., KinD v0.5.1, Docker Desktop:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We don't need the Kubernetes fields)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how experienced you are with Git, but I can merge this then take another PR if it's easier for you @reetasingh ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.youtube.com/watch?v=8j0H6urZ-bU

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added a new commit and rebased my PR

@reetasingh
Add PR and Issue template
254325f 
Signed-off-by: reetasingh <[email protected]>
@derek
Copy link

derek bot commented Aug 27, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Aug 27, 2021
@derek derek bot removed the no-dco label Aug 27, 2021
@reetasingh reetasingh closed this Jun 5, 2022
@alexellis
Copy link
Member

Sorry to see that you had issues getting your sign off correct.

I think this PR might still be needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis Awaiting requested review from alexellis

Assignees
No one assigned
Labels
invalid This doesn't seem right new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add issue and PR templates from inlets-pro repo here
2 participants
@reetasingh @alexellis