No ArgoCD diff on self hosted variant

[FlorisFeddema]

I have tried to deploy the self hosted version on Kubernetes on my homelab. (https://github.com/FlorisFeddema/homelab/tree/main/products/infro)

It places a comment on my github pull requests but does not show a diff. There are also no error logs about this. (FlorisFeddema/homelab#866 (comment))

Used config:

deployers:
  - type: argocd
    name: homelab
    endpoint: argocd.feddema.dev:443
    authtoken: redacted
vcs:
  type: github
  authtoken: ### redacted

[fcrespofastly]

Trying to do the same. In my case I see:

Pull down action image 'infrolabs/infro-core'
  /usr/bin/docker pull infrolabs/infro-core
  Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
  Using default tag: latest

So it fails because cannot mount the socket daemon which obviusly won't work on kubernetes unless some dirty hacks I don't want to do.

[FlorisFeddema]

My deployment does not use the docker.sock, as it should not need it to run the selfhosted option.

[fcrespofastly]

I'm actually talking about github action self-hosted runners, sorry for the confusion

[FlorisFeddema]

It might be better to create a seperate issue for that, seems like to make it work without docker would require a large change in how it works. 😄

[colethienes]

Hey Floris, sorry for the late reply - I've changed the error handling to bubble-up any unexpected CLI errors, which I think should at least show what your issue is: c2293d7

Let me know if you're able to see the issue now.

[FlorisFeddema]

I have since fixed it, it was a configuration mistake on my end. Sorry for not updating the issue!

But better error handling is always welcome 👍🏼