Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isAlive compatible in threading #8

Closed
wants to merge 20 commits into from
Closed

Conversation

dmknght
Copy link

@dmknght dmknght commented Jan 31, 2021

Fix #7

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

Fix #9

  • Add Entry for URL in ForceLoginDialog
  • Add Entry for URL in AuthDialog
  • Fix a crash when user didn't login at faraday_client/persistence/server/server.py (Login bug makes server_url became None type)
    Complete Create Login widget instead of login from CLI #5
  • The function login which asks user's login info in terminal now is called when user pass --login flag only
    P/s: likely a new bug in check is_authen before calling ForceLoginDialog forces program to ask user login time to time.

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

it is not a bug but the way it was created. ForceLogin was made without CONF.saveConfig() so, my questions are, if devs can kindly check my PR:

  • What if the server has 2FA and ForceLoginDialog is used for first login? It should be as same as AuthDialog which has 2FA Entry?
  • Do ForceLoginDialog need saveConfig()? Did it created like that or it was created like template feature and it wasn't fully added?

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

Force Login using GUI (no terminal prompt)

  • problem 1: title
  • problem 2: not start in center of screen
  • problem 3: When user click exit (main widget), dialog isn't destroyed
    image

AuthDialog that has new extra entry for custom URL. The URL is parsed from config or hard coded default localhost if it is empty
image

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

Added title as "Faraday Login" (as same as AuthDialog) for ForceLoginDialog. now it only has 2 problems:

  • Not start at center
  • Dialog should be destroyed if user click on exit button or click Cancel (not very important).
    p/s: likely it is GTK bug when dialog ins't destroyed if main app is shutting down

@aenima-x
Copy link
Contributor

@dmknght we will check it.
But keep in mind that this is deprecated.
We are replacing it with https://github.com/infobyte/faraday-cli

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

But keep in mind that this is deprecated.

That is a bad news to me. I think the gui is really useful to me. Is there any plan to improve GUI in the future or dev team will completely drop it? (Well i can understand the problem of maintaining a gui application and limitation of GUI framework but some improvement could be good)

We are replacing it with https://github.com/infobyte/faraday-cli
It is really nice!

@aenima-x
Copy link
Contributor

@dmknght We have a lot of problems with the dependencies, specially in new versions of osx.
and we think the cli is better for devsecops.
Please give it a try and tell us if you found some missing feature

@dmknght
Copy link
Author

dmknght commented Jan 31, 2021

Please give it a try and tell us if you found some missing feature

I will create more pull requests then maybe can ask some guys to help me do it.
I'm having a short plan that remove CLI modules in this repo and try to do code improvement a little bit so maybe this repo can have new release (but i'm not sure about other platforms like Windows or OSX. I am having only Linux).

@aenima-x
Copy link
Contributor

aenima-x commented Feb 1, 2021

I would like to know why the new cli don't work for you.
That feedback will help us to make improvements.
Also we are working in a new api for faraday so eventually the GTK client will not work any more

@dmknght
Copy link
Author

dmknght commented Feb 2, 2021

I would like to know why the new cli don't work for you.

Oh no i haven't used it. I just knew it after you tell me in the topic.

The gtk client is still official client for the faraday on Parrot OS (and maybe Kali as well). And to me, it is easier to use zsh from GTK client to do pentest thing while using mouse to check information from GUI.

Also we are working in a new api for faraday so eventually the GTK client will not work any more

I would like to do improvement from my side for GTK and do the API change. I can ask some dude to help me with it. I think it is not very hard because Python is widely used. I can ask some friends and some devs from Parrot team for this. And in my opinion, with customized zsh profiles and some improvements, faraday GTK could be used as official application to do pentesting.

Fix hashlib unicode error
Now report bug dialog is working
@dmknght dmknght closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread method isAlive compatible with python 3.9
2 participants