Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(processors.parser): Add base64 decode for fields #15328

Merged
merged 3 commits into from May 22, 2024
Merged

feat(processors.parser): Add base64 decode for fields #15328

merged 3 commits into from May 22, 2024
+188 −27

Conversation

DStrand1
Copy link
Contributor

@DStrand1 DStrand1 commented May 8, 2024

Summary

Adds a base64 decode option for any field specified in the parse_fields config option.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15130

@DStrand1 DStrand1 self-assigned this May 8, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels May 8, 2024
@DStrand1
Copy link
Contributor Author

DStrand1 commented May 8, 2024

@RodrigoDornelles are you able to test if this works as you expect? Thanks!

@RodrigoDornelles
Copy link

I am currently homeless, no longer have my computer.

😕

@DStrand1 DStrand1 assigned powersj and srebhan and unassigned DStrand1 May 13, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 13, 2024
@powersj
Copy link
Contributor

powersj commented May 13, 2024

I am currently homeless, no longer have my computer.

😕

Really sorry to hear about this :( I hope you are ok and are able to get re-established.

powersj
powersj approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj removed their assignment May 13, 2024
srebhan
srebhan reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1 thanks for the PR, we might get some benefit by splitting the fields into two different slices and iterate them separately...

plugins/processors/parser/parser.go Outdated Show resolved Hide resolved
plugins/processors/parser/parser.go Outdated Show resolved Hide resolved
@DStrand1 DStrand1 requested a review from srebhan May 16, 2024 19:27
srebhan
srebhan reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestion to minimize the intrusiveness...

plugins/processors/parser/parser.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @DStrand1!

@srebhan srebhan assigned powersj and unassigned srebhan May 22, 2024
@srebhan srebhan requested a review from powersj May 22, 2024 06:50
@srebhan
Copy link
Contributor

srebhan commented May 22, 2024

@powersj could you please take another look after the code change!?

powersj
powersj approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the updates!

@powersj powersj merged commit 6f29422 into influxdata:master May 22, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 22, 2024
@powersj powersj mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

feat(processors.parser): Add base64 decode option
4 participants
@DStrand1 @RodrigoDornelles @powersj @srebhan