Fix to #829 #845
Open
Fix to #829 #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickhilliard
added
Bug
and removed
Pending CLA
|
I've had a look at this, but fixing this properly is likely to be more complicated than this patch, e.g. startup considerations, etc. I'll have another look before working out what the best approach is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BF] Unconditionally re-initialize sFlow collector counters - fixes #829
Previously the counters were not reset in case the API was unreachable. After writing data to RRDs new counters need to be initialized unconditionally.
In addition to the above, I have:
<?= $t->ee( $data ) ?>or equivalent.