Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use scikit-build-core #755

Merged
merged 54 commits into from
Jun 5, 2024
Merged

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented May 10, 2024

This appears to fix #753.

TODO:

Please squash

@alexfikl
Copy link
Contributor

If we want to switch, why not meson-python instead? The numpy / scipy / matplotlib ecosystem seems to have gone that way and it's probably a good idea to follow..

@matthiasdiener
Copy link
Contributor Author

If we want to switch, why not meson-python instead? The numpy / scipy / matplotlib ecosystem seems to have gone that way and it's probably a good idea to follow..

TIL, thanks! I think the main reason for using scikit-build-core is that it is what nanobind recommends, and it's used in their examples.

@matthiasdiener
Copy link
Contributor Author

This seems to work fine and is ready for a first look @inducer. I'm not sure what the best way to replace/reimplement the configure.py functionality is.

@alexfikl
Copy link
Contributor

This seems to work fine and is ready for a first look @inducer. I'm not sure what the best way to replace/reimplement the configure.py functionality is.

What functionality exactly? Generally the configuration can be done in CMakeLists.txt and you can pass it arguments using

pip install . --config-settings='cmake.args=-DSOME_DEFINE=ON;-DOTHER=OFF'

pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented May 30, 2024

I've pushed the branch to Gitlab to check CI there (added a link to the description for easy access). While main currently doesn't pass on Gitlab either 😢, there are some issues there that might merit a look, particularly the downstream failures.

@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented May 30, 2024

I've pushed the branch to Gitlab to check CI there (added a link to the description for easy access). While main currently doesn't pass on Gitlab either 😢, there are some issues there that might merit a look, particularly the downstream failures.

I think the 'downstream' Gitlab tests should be fixed now ('examples'/'K40' tests fail with main on Gitlab too), but I don't see a way to retrigger the CI run on Gitlab.

@matthiasdiener
Copy link
Contributor Author

Not sure what's going on with the boxtree test (failure seems to be spurious?), but gitlab tests seem to be fixed.

@inducer
Copy link
Owner

inducer commented May 31, 2024

We can't really get a clean test run on Gitlab because of inducer/pytools#227, so I'll put this on hold until we can.

@inducer
Copy link
Owner

inducer commented May 31, 2024

Nvm, we can, now that the release is yanked.

@inducer
Copy link
Owner

inducer commented Jun 5, 2024

LGTM. Thanks for making this happen. Let's do it!

@inducer inducer merged commit 4d17c2f into inducer:main Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install . causes messy directory layout
3 participants