-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring model changes if model is set to string #305
Comments
With the additional watch shown above, there is a problem with validation - the value is not validated and is show invalid required even if set. The solution is to modify momentToValue method instead of adding a watch: exports.momentToValue = function (momentObject, format) {
if (typeof momentObject === "string") {
momentObject = moment(momentObject);
}
if (!exports.isValidMoment(momentObject))
return undefined;
return !format ? momentObject.valueOf() : momentObject.format(format);
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Input:
If model is set to string - it is ignored. See Plunkr
I have no TS coding experience, so I made changes to JS directly. See Plunkr
The change I made is adding one more watcher after the watcher
if ($attrs['ngModel'] != $attrs['momentPicker'])
:You can check the exact change at this comit
The text was updated successfully, but these errors were encountered: